Rollup of 9 pull requests #134137

fmease · 2024-12-10T19:16:08Z

Successful merges:

Fix typo (exit → exist) #133583 (Fix type (exit → exist))
Add the power8-crypto target feature #134042 (Add the power8-crypto target feature)
Tweak wording of non-const traits used as const bounds #134094 (Tweak wording of non-const traits used as const bounds)
Remove rustc_const_stable attribute on const NOOP #134100 (Remove rustc_const_stable attribute on const NOOP)
Don't ICE when encountering never in range pattern #134103 (Don't ICE when encountering never in range pattern)
run-make: Fix assert_stderr_not_contains_regex #134113 (run-make: Fix assert_stderr_not_contains_regex)
rustc_target: ppc64 target string fixes for LLVM 20 #134115 (rustc_target: ppc64 target string fixes for LLVM 20)
stabilize const_nonnull_new #134116 (stabilize const_nonnull_new)
Remove Felix from ping groups and review rotation #134120 (Remove Felix from ping groups and review rotation)

r? @ghost
@rustbot modify labels: rollup

This was accidentally reintroduced while editing rust-lang#133089.

Use verbose suggestions and add additional labels/notes. Add more test cases for stable/nightly and feature enabled/disabled.

It asserted on **stdout**, not stderr.

LLVM continues to clean these up, and we continue to make this consistent. This is similar to 9caced7, e985396, and a10e744. `@rustbot` label: +llvm-main

Fix type (exit → exist)

Add the `power8-crypto` target feature Add the `power8-crypto` target feature. This will enable adding some new PPC intrinsics in stdarch (specifically AES, SHA and CLMUL intrinsics). The implied target feature is from [here](https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/PowerPC/PPC.td) ```@rustbot``` label A-target-feature O-PowerPC

…piler-errors Tweak wording of non-const traits used as const bounds Use verbose suggestions and add additional labels/notes. r? ``@compiler-errors``

…tolnay Remove rustc_const_stable attribute on const NOOP This was accidentally reintroduced while editing rust-lang#133089. r? dtolnay

…=oli-obk Don't ICE when encountering never in range pattern Fixes rust-lang#133947 r? oli-obk

run-make: Fix `assert_stderr_not_contains_regex` It asserted on **stdout**, not stderr. r? ``@jieyouxu``

…youxu rustc_target: ppc64 target string fixes for LLVM 20 LLVM continues to clean these up, and we continue to make this consistent. This is similar to 9caced7, e985396, and a10e744. ```@rustbot``` label: +llvm-main

stabilize const_nonnull_new FCP passed in rust-lang#93235 Closes rust-lang#93235

Remove Felix from ping groups and review rotation

fmease · 2024-12-10T19:16:19Z

@bors r+ rollup=never p=5

bors · 2024-12-10T19:16:22Z

📌 Commit e60f6cd has been approved by fmease

It is now in the queue for this repository.

bors · 2024-12-10T20:41:02Z

⌛ Testing commit e60f6cd with merge 8448734...

Rollup of 9 pull requests Successful merges: - rust-lang#133583 (Fix type (exit → exist)) - rust-lang#134042 (Add the `power8-crypto` target feature) - rust-lang#134094 (Tweak wording of non-const traits used as const bounds) - rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP) - rust-lang#134103 (Don't ICE when encountering never in range pattern) - rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`) - rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20) - rust-lang#134116 (stabilize const_nonnull_new) - rust-lang#134120 (Remove Felix from ping groups and review rotation) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2024-12-10T23:05:08Z

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 29.357
error: linking with `i686-w64-mingw32-gcc` failed: exit code: 1
  |
  = note: "i686-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--dynamicbase" "-Wl,--disable-auto-image-base" "-Wl,--large-address-aware" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\symbols.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-659084248a5844d9.rustc_main.e12aca79d7217625-cgu.0.rcgu.o" "-Wl,-Bdynamic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_driver-feab0383960d185a.dll" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\std-85e8e1afc0a1e2c0.dll" "-Wl,-Bstatic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\libcompiler_builtins-d77c9d76f065957b.rlib" "-Wl,-Bdynamic" "-lpsapi" "-lshell32" "-lole32" "-luuid" "-ladvapi32" "-lws2_32" "-lntdll" "-lkernel32" "-ladvapi32" "-lole32" "-loleaut32" "-ladvapi32" "-lcfgmgr32" "-lgdi32" "-lkernel32" "-lmsimg32" "-lopengl32" "-luser32" "-lwinspool" "-lbcrypt" "-ladvapi32" "-lkernel32" "-lkernel32" "-ladvapi32" "-lntdll" "-luserenv" "-lws2_32" "-ldbghelp" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc5aV8Qp\\wofutil.dll_imports_indirect.lib" "-lgcc_s" "-lmsvcrt" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-lmingwex" "-luser32" "-lkernel32" "-Wl,--nxcompat" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\stacker-d3f5f2020a9db92d\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\psm-a8e1851838120981\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\blake3-0d7379973d66d445\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\rustc_llvm-9c1d12dc9076cada\\out" "-L" "C:/a/rust/rust/build/i686-pc-windows-gnu/llvm/lib" "-L" "C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0" "-o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-659084248a5844d9.exe" "-Wl,--gc-sections" "-no-pie" "-Wl,-O1" "-nodefaultlibs" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
  = note: C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0/../../../../i686-w64-mingw32/bin/ld.exe: cannot open output file C:\a\rust\rust\build\i686-pc-windows-gnu\stage1-rustc\i686-pc-windows-gnu\release\deps\rustc_main-659084248a5844d9.exe: Invalid argument␍
          collect2.exe: error: ld returned 1 exit status

[RUSTC-TIMING] rustc_main test:false 4.060
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:33:54

bors · 2024-12-10T23:05:46Z

💔 Test failed - checks-actions

fmease · 2024-12-10T23:08:58Z

@bors retry

bors · 2024-12-11T01:26:24Z

⌛ Testing commit e60f6cd with merge 5726725...

Rollup of 9 pull requests Successful merges: - rust-lang#133583 (Fix type (exit → exist)) - rust-lang#134042 (Add the `power8-crypto` target feature) - rust-lang#134094 (Tweak wording of non-const traits used as const bounds) - rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP) - rust-lang#134103 (Don't ICE when encountering never in range pattern) - rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`) - rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20) - rust-lang#134116 (stabilize const_nonnull_new) - rust-lang#134120 (Remove Felix from ping groups and review rotation) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2024-12-11T03:47:11Z

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 28.622
error: linking with `i686-w64-mingw32-gcc` failed: exit code: 1
  |
  = note: "i686-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--dynamicbase" "-Wl,--disable-auto-image-base" "-Wl,--large-address-aware" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\symbols.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-659084248a5844d9.rustc_main.956258181ff7f0f3-cgu.0.rcgu.o" "-Wl,-Bdynamic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_driver-feab0383960d185a.dll" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\std-85e8e1afc0a1e2c0.dll" "-Wl,-Bstatic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\libcompiler_builtins-d77c9d76f065957b.rlib" "-Wl,-Bdynamic" "-lpsapi" "-lshell32" "-lole32" "-luuid" "-ladvapi32" "-lws2_32" "-lntdll" "-lkernel32" "-ladvapi32" "-lole32" "-loleaut32" "-ladvapi32" "-lcfgmgr32" "-lgdi32" "-lkernel32" "-lmsimg32" "-lopengl32" "-luser32" "-lwinspool" "-lbcrypt" "-ladvapi32" "-lkernel32" "-lkernel32" "-ladvapi32" "-lntdll" "-luserenv" "-lws2_32" "-ldbghelp" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVQNGbr\\wofutil.dll_imports_indirect.lib" "-lgcc_s" "-lmsvcrt" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-lmingwex" "-luser32" "-lkernel32" "-Wl,--nxcompat" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\stacker-d3f5f2020a9db92d\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\psm-a8e1851838120981\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\blake3-0d7379973d66d445\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\rustc_llvm-9c1d12dc9076cada\\out" "-L" "C:/a/rust/rust/build/i686-pc-windows-gnu/llvm/lib" "-L" "C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0" "-o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-659084248a5844d9.exe" "-Wl,--gc-sections" "-no-pie" "-Wl,-O1" "-nodefaultlibs" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
  = note: C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0/../../../../i686-w64-mingw32/bin/ld.exe: cannot open output file C:\a\rust\rust\build\i686-pc-windows-gnu\stage1-rustc\i686-pc-windows-gnu\release\deps\rustc_main-659084248a5844d9.exe: Invalid argument␍
          collect2.exe: error: ld returned 1 exit status

[RUSTC-TIMING] rustc_main test:false 3.883
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:33:32

bors · 2024-12-11T03:47:58Z

💔 Test failed - checks-actions

fmease · 2024-12-11T05:27:59Z

@bors retry

bors · 2024-12-11T05:31:50Z

⌛ Testing commit e60f6cd with merge 5a6036a...

bors · 2024-12-11T08:15:57Z

☀️ Test successful - checks-actions
Approved by: fmease
Pushing 5a6036a to master...

rust-timer · 2024-12-11T08:18:33Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#133583	Fix type (exit → exist)	`e42bee46e51ac6a75a659822c5c4d7bebe8242dd` (link)
#134042	Add the `power8-crypto` target feature	`ff9c59f39a1f8187d17e9089988a3ce6992b642b` (link)
#134094	Tweak wording of non-const traits used as const bounds	`3aba02d4c1bef55d98f6ddd1b8b6f41469277999` (link)
#134100	Remove rustc_const_stable attribute on const NOOP	`2bb230a3df4c9d4ef21cdf1fd15eb560dd713797` (link)
#134103	Don't ICE when encountering never in range pattern	`040dac144db68938e1cc55d3ff80bf6b5b4858bd` (link)
#134113	run-make: Fix `assert_stderr_not_contains_regex`	`412aa0d1cdb88aaf69238f596172c8c0777e4ffd` (link)
#134115	rustc_target: ppc64 target string fixes for LLVM 20	`037cd0a406fe9bad323effa5ea089118788f1adb` (link)
#134116	stabilize const_nonnull_new	`0344c5b631b767d8291072a7c3752db3ec12cf4f` (link)
#134120	Remove Felix from ping groups and review rotation	`0196c7ee61bc19078b774f3a57c885263071f42b` (link)

previous master: 33c245b9e9

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-12-11T09:33:44Z

Finished benchmarking commit (5a6036a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Max RSS (memory usage)

Results (primary 1.2%, secondary -2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[0.9%, 4.4%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-2.7%	[-4.2%, -1.2%]	2
All ❌✅ (primary)	1.2%	[-1.6%, 4.4%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.372s -> 767.862s (-0.07%)
Artifact size: 331.03 MiB -> 331.04 MiB (0.00%)

sayantn and others added 18 commits December 9, 2024 00:41

Add the power8-crypto target feature

1220f39

Remove rustc_const_stable attribute on const NOOP

b9afc78

This was accidentally reintroduced while editing rust-lang#133089.

Tweak wording of non-const traits used as const bounds

4007fc9

Use verbose suggestions and add additional labels/notes. Add more test cases for stable/nightly and feature enabled/disabled.

Don't ICE when encountering never in pattern

6e2e9f6

run-make: Fix assert_stderr_not_contains_regex

9a6deba

It asserted on **stdout**, not stderr.

stabilize const_nonnull_new

a8d11ea

rustc_target: ppc64 target string fixes for LLVM 20

0680155

LLVM continues to clean these up, and we continue to make this consistent. This is similar to 9caced7, e985396, and a10e744. `@rustbot` label: +llvm-main

Fix type (exit → exist)

bab1fcb

Remove Felix from ping groups and review rotation

e1689e6

Rollup merge of rust-lang#133583 - tbu-:pr_fix_typo2, r=compiler-errors

5bd9602

Fix type (exit → exist)

Rollup merge of rust-lang#134094 - estebank:const-trait-errors, r=com…

185440a

…piler-errors Tweak wording of non-const traits used as const bounds Use verbose suggestions and add additional labels/notes. r? ``@compiler-errors``

Rollup merge of rust-lang#134100 - eholk:noop-rustc-const-stable, r=d…

f621be4

…tolnay Remove rustc_const_stable attribute on const NOOP This was accidentally reintroduced while editing rust-lang#133089. r? dtolnay

Rollup merge of rust-lang#134103 - compiler-errors:never-pat-range, r…

c5a8386

…=oli-obk Don't ICE when encountering never in range pattern Fixes rust-lang#133947 r? oli-obk

Rollup merge of rust-lang#134113 - jyn514:run-make-contains, r=jieyouxu

0b9e74a

run-make: Fix `assert_stderr_not_contains_regex` It asserted on **stdout**, not stderr. r? ``@jieyouxu``

Rollup merge of rust-lang#134116 - RalfJung:const_nonnull_new, r=jhpratt

e822dfc

stabilize const_nonnull_new FCP passed in rust-lang#93235 Closes rust-lang#93235

Rollup merge of rust-lang#134120 - oli-obk:push-vryonyoqmonv, r=oli-obk

e60f6cd

Remove Felix from ping groups and review rotation

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 10, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2024

fmease added the CI-spurious-fail-mingw CI spurious failure: target env mingw label Dec 10, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 11, 2024

bors merged commit 5a6036a into rust-lang:master Dec 11, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 11, 2024

This was referenced Dec 11, 2024

forbid toggling x87 and fpregs on hard-float targets #133099

Merged

Move impl constness into impl trait header #134122

Merged

fmease deleted the rollup-u1p7swx branch December 11, 2024 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #134137

Rollup of 9 pull requests #134137

Uh oh!

fmease commented Dec 10, 2024

Uh oh!

fmease commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

rust-log-analyzer commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

fmease commented Dec 10, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

rust-log-analyzer commented Dec 11, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

fmease commented Dec 11, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

Uh oh!

rust-timer commented Dec 11, 2024

Uh oh!

rust-timer commented Dec 11, 2024

Uh oh!

Uh oh!

Rollup of 9 pull requests #134137

Rollup of 9 pull requests #134137

Uh oh!

Conversation

fmease commented Dec 10, 2024

Uh oh!

fmease commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

rust-log-analyzer commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

fmease commented Dec 10, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

rust-log-analyzer commented Dec 11, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

fmease commented Dec 11, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

Uh oh!

rust-timer commented Dec 11, 2024

Uh oh!

rust-timer commented Dec 11, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!